-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve natlab logs #1149
Open
lcruz99
wants to merge
6
commits into
main
Choose a base branch
from
improve_natlab_logs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Improve natlab logs #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c754660
to
f5e6a0d
Compare
1b1e7e6
to
9b042bf
Compare
9b042bf
to
a1515c6
Compare
a1515c6
to
1f8d28f
Compare
1f8d28f
to
f70a8d7
Compare
f5e6a0d
to
318c115
Compare
bc211dc
to
9bc68c6
Compare
9bc68c6
to
fc62af9
Compare
fc62af9
to
4f922f6
Compare
d7f9175
to
2c1857b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With #1143 the nat-lab logs were cleaned, during that task execution it was realized that the logs were still too verbose, many adding trivial information.
Nat-lab could also make use of a logger to standardize logs format and providing the user the option to choose the amount of verbosity.
Solution
Remove trivial logs and add a few others, mainly add a logger.
☑️ Definition of Done checklist