Force Pyro to timeout quickly and introduce retries #1095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
2f6dec1 to
7b94f4e
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
7b94f4e to
aa38753
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
aa38753 to
5eda99f
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
5eda99f to
9f607fd
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
9f607fd to
5bb7779
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
5bb7779 to
9c0b45d
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
9c0b45d to
32d7752
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
32d7752 to
d3c5970
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
d3c5970 to
386c250
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
386c250 to
3a546a3
Compare
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
3a546a3 to
105cdb4
Compare
We observe that sometimes pyro remote calls are with time gaps in between which should not happen. We guess it might be due to network issues. However the packets still arrive and might be due to TCP retransmission. Pyro has a timeout property which is not exposed publicly. This property is set and looped over if timeout error is returned to fix the issue. Signed-off-by: Lukas Pukenis <[email protected]>
LukasPukenis
force-pushed
the
LLT-5975/pyro_timeouts
branch
from
105cdb4 to
06c8008
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We observe that sometimes pyro remote calls are with time gaps in between which should not happen. We guess it might be due to network issues. However the packets still arrive and might be due to TCP retransmission.
Pyro has a timeout property which is not exposed publicly. This property is set and looped over if timeout error is returned to fix the issue.
Problem
--describe problem being solved--
Solution
--describe selected solution--
☑️ Definition of Done checklist