Fix dod status on merge queue #1089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjanowsk
requested review from
Jauler,
packgron,
tomaszklak,
LukasPukenis and
a team
as code owners
Seems that skipped status is not enough, we need success status for check-dod job. So let's execute checkout always and dod step only when we should.
jjanowsk
force-pushed
the
jj_merge_queue_3
branch
from
9921da4 to
3270af6
Compare
Otherwise it can have skipped status which in some cases github interprets as success
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems that skipped status is not enough, we need success status for check-dod job. So let's execute checkout always and dod step only when we should.
☑️ Definition of Done checklist