-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust pkgs meson file for transitioning M4AGO #414
Conversation
…t version Only relevant, when compiled via meson setups
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmaerz - thanks, this looks fine to me
One question, is the testing on file existing intended as a transitional fix, or will this be permanent? I'm wondering, if we need to introduce such a test every time a file is added/removed/renamed in a submodule, or only until a new tag version is available?
Hi @TomasTorsvik , to my understanding and according to the meson documentation, each |
Hi @jmaerz , from our latest conversation I understand that including this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say anything about this - I have never used a non-CESM-coupled version of BLOM and I have no knowledge about how meson works.
This PR informs about potential issues when setting up a run with meson - cime-managed runs are NOT affected.
The PR provides support for any of the current M4AGO versions provided meson >= 0.57 is used.
Background
I recently worked on the M4AGO-sinking-scheme package and introduced a new file, which requires to be explicitly set via
meson.build
. Typically, a particular tag/sha of M4AGO is checked out (where this change isn't needed), but if one for any reason moves on to M4AGOmaster
, this will create issues when compiling with meson. The code snippet is applicable for meson versions >=0.57, where the meson file system module has been introduced. Otherwise, the file needs to be manually added in themeson.build
file. Hope it helps in the current transition period for M4AGO which is for making it more general and future-ready.@JorgSchwinger and @TomasTorsvik : if wished, I can push it to
master
- I was just hesitant since the required meson release was Feb. 2021, which isn't too long ago.@matsbn : I put you in here explicitly, since I know that you are using meson every now and then (not sure, which meson version you're running, though).