[Feat/NST-10] #38 회원가입 화면 작성 #39
Merged
+674
−186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thingineeer
approved these changes
Feb 26, 2025
Comment on lines
+10
to
+18
| protocol UserUseCaseProtocol { | ||
| func validate(name: String) -> Observable<ValidationResult> | ||
| } | ||
|
|
||
| final class UserUseCase: UserUseCaseProtocol { | ||
| func validate(name: String) -> Observable<ValidationResult> { | ||
| return Observable.just(SignUpValidator.validate(name: name)) | ||
| } | ||
| } |
| struct SignUpValidator { | ||
| static func validate(name: String) -> ValidationResult { | ||
| // 1. 글자 수 제한 (1~10자) | ||
| guard (1...10).contains(name.count) else { |
There was a problem hiding this comment.
저는 범위연산자 사용하는데 이렇게도 할 수 있군요?
1...10 ~= name.count
There was a problem hiding this comment.
오호 이렇게 해도 좋겠네요! 👍👍👍
Comment on lines
+47
to
+55
| if let placeholder { | ||
| textField.setPlaceholder( | ||
| text: placeholder, | ||
| color: .appGray600, | ||
| font: .PretendardStyle.b5_r.font | ||
| ) | ||
| } | ||
| if let countLimit { setCountLabelBinding(limit: countLimit) } | ||
| if activateDeleteButton { setDeleteButton() } |
There was a problem hiding this comment.
이 부분을 함수로 나누지 않은 이유를 들어보고 싶습니다!
There was a problem hiding this comment.
init 부분에서 각 입력값에 따라 UI 세팅이 될 수 있도록 작성했습니다!
각 세팅 내용을 함수로 나누고, init에서 하나씩 작성하여 init 때 해당 내용이 해당 조건에 실행됨을 명확히 하기위해 작성했습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔥 Issue
#38
🔥 변경된 내용
🔥 PR Point
기존 텍스트 사용 방법은 변함 없으나, Rx를 통한 state와 deleteButtonTap 사용에서 일부 변화가 있습니다
사용법은 아래와 같습니다.
// 사용자의 텍스트필트 X 버튼 탭 rootView.nameTextField.rx.deleteButtonTapped .debounce(.milliseconds(100), scheduler: MainScheduler.instance) .map { SignUpReactor.Action.tapNameDeleteButton } .bind(to: reactor.action) .disposed(by: disposeBag) // State의 이름 텍스트필드 상태 UI 반영 reactor.state.map { $0.nameTextFieldState } .distinctUntilChanged() .bind(to: rootView.nameTextField.rx.state) .disposed(by: disposeBag)🔥 ScreenShot
🔥 Reference