Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow defining built-ins types and functions only inside relevant contexts #1203

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ggiraldez
Copy link
Contributor

@ggiraldez ggiraldez commented Dec 24, 2024

The changes in this PR would allow us to remove all Yul keywords defined for built-ins and declare them as built-ins, to be bound only in assembly statements context. This would simplify the language grammar.

  • add BuiltInContext to separate built-ins.
  • delete YulBuiltInFunction, and merge its children with the newly created BuiltInContext(name = "$YulBuiltIns$").
  • add snapshot tests to make sure they are still bound correctly in Yul.
  • add snapshot tests to make sure Solidity built-ins are only bound inside Solidity, and vise-versa.

Copy link

changeset-bot bot commented Dec 24, 2024

⚠️ No Changeset found

Latest commit: 102809c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…ing `BuiltInContext`

This version is very broken but it represents most of the initial changes to `definitions.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants