Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network plugin cleanup #6119

Merged
merged 18 commits into from
Jan 14, 2025
Merged

Network plugin cleanup #6119

merged 18 commits into from
Jan 14, 2025

Conversation

schaable
Copy link
Member

@schaable schaable commented Jan 7, 2025

No description provided.

@schaable
refactor: keep http headers consistent between provider types
57ed29d
@schaable
refactor: rename ConfigurationResolver to ConfigurationVariableResolv…
ec9e94a 
…er for clarity
@schaable
refactor: move constants to separate file to avoid unnecessary packag…
b33854b 
…e loading
@schaable
feat: return precomputed accounts for edr and simplify logic
4c27150
@schaable
feat: map the hardhat chain type to edr
2b57e81
@schaable
fix: add mising async keyword
3a9f249
@schaable
doc: update comment to better reflect logic
73cb7b7
@schaable
refactor: extract shared logic to a BaseProvider
ea69116
@schaable
refactor: remove obsolete code from http provider
3335922
@schaable
fix: typo in handlers-array filename
724f6bb
@schaable
fix: update getRequestParams to return unknown[]
00578af
@schaable
fix: make object properties deeply immutable
da8e44b
@schaable
refactor: use constants for chain type values
c8caba7
@schaable
refactor: cleanup rpc utils
1869702
@schaable schaable added the v-next A Hardhat v3 development task label Jan 7, 2025
@schaable schaable self-assigned this Jan 7, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 26f7733

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jan 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 6:59pm

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Jan 7, 2025
@schaable schaable changed the title [WIP] Network plugin cleanup Network plugin cleanup Jan 14, 2025
@schaable schaable marked this pull request as ready for review January 14, 2025 18:37
Base automatically changed from edr-config-validation to v-next January 14, 2025 18:49
@schaable schaable enabled auto-merge January 14, 2025 18:59
@schaable schaable added this pull request to the merge queue Jan 14, 2025
Merged via the queue into v-next with commit 7e815f5 Jan 14, 2025
55 checks passed
@schaable schaable deleted the network-plugin-cleanup branch January 14, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alcuadrado alcuadrado alcuadrado approved these changes

Assignees

@schaable schaable

Labels
status:ready This issue is ready to be worked on v-next A Hardhat v3 development task
Projects
Hardhat
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schaable @alcuadrado