all ignition packages linting successfully

NomicFoundation · Jan 16, 2025 · a37b251 · a37b251
1 parent 5dafa9d
commit a37b251
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 14 deletions.
diff --git a/packages/hardhat-ignition-core/src/internal/journal/memory-journal.ts b/packages/hardhat-ignition-core/src/internal/journal/memory-journal.ts
@@ -10,18 +10,18 @@ import { emitExecutionEvent } from "./utils/emitExecutionEvent";
  * @beta
  */
 export class MemoryJournal implements Journal {
-  private messages: JournalMessage[] = [];
+  private _messages: JournalMessage[] = [];
 
   constructor(private _executionEventListener?: ExecutionEventListener) {}
 
   public record(message: JournalMessage): void {
     this._log(message);
 
-    this.messages.push(message);
+    this._messages.push(message);
   }
 
   public async *read(): AsyncGenerator<JournalMessage> {
-    for (const message of this.messages) {
+    for (const message of this._messages) {
       yield message;
     }
   }

diff --git a/.../hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts b/.../hardhat-ignition-core/test-integrations/new-api/internal/new-execution/jsonrpc-client.ts
@@ -53,15 +53,15 @@ describe("JSON-RPC client", function () {
       return { artifact, address: receipt!.contractAddress! };
     }
 
-    describe("getChainId", async function () {
+    describe("getChainId", function () {
       it("Should return the chainId as number", async function () {
         const chainId = await client.getChainId();
 
         assert.equal(chainId, 31337);
       });
     });
 
-    describe("getLatestBlock", async function () {
+    describe("getLatestBlock", function () {
       it("Should return the first block in the correct format", async function () {
         const block = await client.getLatestBlock();
 
@@ -80,7 +80,7 @@ describe("JSON-RPC client", function () {
       });
     });
 
-    describe("getNetworkFees", async function () {
+    describe("getNetworkFees", function () {
       describe("With an EIP-1559 network (i.e. Hardhat Network)", function () {
         it("Should return information about EIP-1559 fees", async function () {
           const fees = await client.getNetworkFees();

diff --git a/packages/hardhat-ignition-core/test/execution/abi.ts b/packages/hardhat-ignition-core/test/execution/abi.ts
@@ -507,7 +507,7 @@ describe("abi", () => {
           });
         });
 
-        describe("When the function returns something and there's no clash", async () => {
+        describe("When the function returns something and there's no clash", () => {
           it("should return RevertWithoutReason", async () => {
             const { decoded } = decode("C", "revertWithoutReasonWithoutClash");
             assert.deepEqual(decoded, {
@@ -631,7 +631,7 @@ describe("abi", () => {
           });
         });
 
-        describe("When the function returns something and there's no clash", async () => {
+        describe("When the function returns something and there's no clash", () => {
           it("should return RevertWithoutReason", async () => {
             const { decoded } = decode("C", "invalidOpcode");
             assert.deepEqual(decoded, {

diff --git a/packages/hardhat-ignition-ethers/README.md b/packages/hardhat-ignition-ethers/README.md
@@ -1,5 +1,4 @@
-![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f)
-[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
+![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
 
 ---
 

diff --git a/packages/hardhat-ignition-viem/README.md b/packages/hardhat-ignition-viem/README.md
@@ -1,5 +1,4 @@
-![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f)
-[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition-viem.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
+![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition-viem.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org)
 
 ---
 

diff --git a/packages/hardhat-ignition/README.md b/packages/hardhat-ignition/README.md
@@ -1,5 +1,4 @@
-![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f)
-[![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) [![Open in Dev Containers](https://img.shields.io/static/v1?label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/NomicFoundation/hardhat-ignition.git)
+![hardhat_Ignition_banner](https://github.com/NomicFoundation/hardhat-ignition/assets/24030/cc73227b-8791-4bb3-bc9a-a39be69d215f) [![npm](https://img.shields.io/npm/v/@nomicfoundation/hardhat-ignition.svg)](https://www.npmjs.com/package/@nomicfoundation/hardhat-ignition) [![hardhat](https://hardhat.org/buidler-plugin-badge.svg?1)](https://hardhat.org) [![Open in Dev Containers](https://img.shields.io/static/v1?label=Dev%20Containers&message=Open&color=blue&logo=visualstudiocode)](https://vscode.dev/redirect?url=vscode://ms-vscode-remote.remote-containers/cloneInVolume?url=https://github.com/NomicFoundation/hardhat-ignition.git)
 
 ---