fix: ignore unknown opcodes in source maps #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 801e351 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fvictorio
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Wodann
requested changes
Jan 6, 2025
fvictorio
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
fvictorio
force-pushed
the
invalid-opcode-bug
branch
from
9a022ba to
c127666
Compare
fvictorio
had a problem deploying
to
github-action-benchmark
GitHub Actions
Error
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
|
The Drop write lock immediately after using it commit is unrelated to this fix, but I ran into that when trying to debug something, and @agostbiro suggested we make that change, since it's a more sane handling of the lock. |
agostbiro
approved these changes
Jan 10, 2025
| let opcode = if let Some(opcode) = OpCode::new(bytecode[pc]) { | ||
| opcode | ||
| } else { | ||
| debug!("Invalid opcode {} at pc: {}", bytecode[pc], pc); |
There was a problem hiding this comment.
nit: I prefer to not to import these macros from log and just write log::debug! so that it's easy to differentiate from tracing::debug!
Wodann
approved these changes
Jan 13, 2025
fvictorio
temporarily deployed
to
github-action-benchmark
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #763.
As far as I can tell, this can only happens when solc produces source maps that have an error, so I think just ignoring this is fine. I'm not adding a test for this because it seems to only happen in very special circumstances, with older versions of solc.