Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Backward compatibility: missing prediction_intervals #1224

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

JQGoh
Copy link
Contributor

@JQGoh JQGoh commented Dec 15, 2024

This addresses #1223

Remove test case with large model file
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@JQGoh
Copy link
Contributor Author

JQGoh commented Dec 15, 2024

@jmoralez @elephaint Please review. At first I planned to add a test with an old model's file, but I realize that it takes about 10MB. I decided to introduce the fix without the test but I managed to validate the fix locally.

@JQGoh
Copy link
Contributor Author

JQGoh commented Dec 15, 2024

@jmoralez
I am not sure how does the NIxtla plan to introduce hot fix such as this. But since we are likely to introduce breaking changes like #1220 and #1015,
will Nixtla consider merging this PR first and do a release, before merging those breaking changes PRs?

neuralforecast/core.py Outdated Show resolved Hide resolved
@jmoralez jmoralez added the fix label Dec 16, 2024
@jmoralez jmoralez merged commit 2d0af6c into Nixtla:main Dec 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] Missing prediction_intervals attribute when saving the NeuralForecast model
2 participants