Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r8126: init at 10.014.01 #376766

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

r8126: init at 10.014.01 #376766

wants to merge 2 commits into from

Conversation

davidkna
Copy link
Contributor

@davidkna davidkna commented Jan 25, 2025

This PR packages the r8126 module linux kernel module, which is required to use realtek 5gbe interfaces. The package definition is based on the r8125 package definition.

Officially only up to 6.8 is supported, but even 6.13 appears to work fine. Since this is a new package, and I wasn't on the maitainers list I added myself and set myself as the package maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Compiled, loaded module, and verified wired networking works.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 25, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 25, 2025
pkgs/os-specific/linux/r8126/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/r8126/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/r8126/default.nix Outdated Show resolved Hide resolved
@davidkna davidkna force-pushed the r8126 branch 2 times, most recently from b24691b to 84ca5f7 Compare January 25, 2025 19:11
@Defelo
Copy link
Member

Defelo commented Jan 25, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376766

Logs: https://github.com/Defelo/nixpkgs-review-gha/actions/runs/12967932486


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4_hardened.r8126
  • linuxPackages_5_4_hardened.r8126
❌ 1 package failed to build:
  • linuxPackages_latest-libre.r8126 (linuxKernel.packages.linux_latest_libre.r8126)
✅ 19 packages built:
  • linuxKernel.packages.linux_5_10.r8126
  • linuxPackages_5_10_hardened.r8126 (linuxKernel.packages.linux_5_10_hardened.r8126)
  • linuxKernel.packages.linux_5_15.r8126
  • linuxPackages_5_15_hardened.r8126 (linuxKernel.packages.linux_5_15_hardened.r8126)
  • linuxKernel.packages.linux_5_4.r8126
  • linuxKernel.packages.linux_6_1.r8126
  • linuxKernel.packages.linux_6_11.r8126
  • linuxPackages_6_11_hardened.r8126 (linuxKernel.packages.linux_6_11_hardened.r8126)
  • linuxPackages.r8126 (linuxKernel.packages.linux_6_12.r8126)
  • linuxPackages_hardened.r8126 (linuxPackages_6_12_hardened.r8126)
  • linuxPackages_latest.r8126 (linuxKernel.packages.linux_6_13.r8126)
  • linuxPackages_6_1_hardened.r8126 (linuxKernel.packages.linux_6_1_hardened.r8126)
  • linuxKernel.packages.linux_6_6.r8126
  • linuxPackages_6_6_hardened.r8126 (linuxKernel.packages.linux_6_6_hardened.r8126)
  • linuxPackages-libre.r8126 (linuxKernel.packages.linux_libre.r8126)
  • linuxPackages_lqx.r8126 (linuxKernel.packages.linux_lqx.r8126)
  • linuxPackages_xanmod.r8126 (linuxKernel.packages.linux_xanmod.r8126)
  • linuxPackages_xanmod_latest.r8126 (linuxKernel.packages.linux_xanmod_latest.r8126 ,linuxPackages_xanmod_stable.r8126)
  • linuxPackages_zen.r8126 (linuxKernel.packages.linux_zen.r8126)

aarch64-linux

⏩ 12 packages marked as broken and skipped:
  • linuxKernel.packages.linux_5_4_hardened.r8126
  • linuxKernel.packages.linux_lqx.r8126
  • linuxKernel.packages.linux_xanmod.r8126
  • linuxKernel.packages.linux_xanmod_latest.r8126
  • linuxKernel.packages.linux_xanmod_stable.r8126
  • linuxKernel.packages.linux_zen.r8126
  • linuxPackages_5_4_hardened.r8126
  • linuxPackages_lqx.r8126
  • linuxPackages_xanmod.r8126
  • linuxPackages_xanmod_latest.r8126
  • linuxPackages_xanmod_stable.r8126
  • linuxPackages_zen.r8126
❌ 2 packages failed to build:
  • linuxKernel.packages.linux_5_4.r8126
  • linuxPackages_latest-libre.r8126 (linuxKernel.packages.linux_latest_libre.r8126)
✅ 14 packages built:
  • linuxKernel.packages.linux_5_10.r8126
  • linuxPackages_5_10_hardened.r8126 (linuxKernel.packages.linux_5_10_hardened.r8126)
  • linuxKernel.packages.linux_5_15.r8126
  • linuxPackages_5_15_hardened.r8126 (linuxKernel.packages.linux_5_15_hardened.r8126)
  • linuxKernel.packages.linux_6_1.r8126
  • linuxKernel.packages.linux_6_11.r8126
  • linuxPackages_6_11_hardened.r8126 (linuxKernel.packages.linux_6_11_hardened.r8126)
  • linuxPackages.r8126 (linuxKernel.packages.linux_6_12.r8126)
  • linuxPackages_hardened.r8126 (linuxPackages_6_12_hardened.r8126)
  • linuxPackages_latest.r8126 (linuxKernel.packages.linux_6_13.r8126)
  • linuxPackages_6_1_hardened.r8126 (linuxKernel.packages.linux_6_1_hardened.r8126)
  • linuxKernel.packages.linux_6_6.r8126
  • linuxPackages_6_6_hardened.r8126 (linuxKernel.packages.linux_6_6_hardened.r8126)
  • linuxPackages-libre.r8126 (linuxKernel.packages.linux_libre.r8126)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants