-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r8126: init at 10.014.01 #376766
Open
davidkna
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
davidkna:r8126
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
r8126: init at 10.014.01 #376766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
label
Jan 25, 2025
github-actions
bot
added
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 11-100
labels
Jan 25, 2025
Defelo
reviewed
Jan 25, 2025
davidkna
force-pushed
the
r8126
branch
2 times, most recently
from
January 25, 2025 19:11
b24691b
to
84ca5f7
Compare
Defelo
reviewed
Jan 25, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 11-100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR packages the r8126 module linux kernel module, which is required to use realtek 5gbe interfaces. The package definition is based on the r8125 package definition.
Officially only up to 6.8 is supported, but even 6.13 appears to work fine. Since this is a new package, and I wasn't on the maitainers list I added myself and set myself as the package maintainer.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Compiled, loaded module, and verified wired networking works.
Add a 👍 reaction to pull requests you find important.