Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whatsapp chat exporter #376761

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

EstebanMacanek
Copy link
Contributor

Version 0.10.5 added a new dependency, but it's missing from package.nix.
https://github.com/KnugiHK/WhatsApp-Chat-Exporter/blob/main/setup.py#L58

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@EstebanMacanek EstebanMacanek force-pushed the fix-whatsapp-chat-exporter branch from 49ea4bd to b2208b5 Compare January 25, 2025 17:56
@bbenno
Copy link
Member

bbenno commented Jan 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376761


x86_64-linux

✅ 2 packages built:
  • whatsapp-chat-exporter
  • whatsapp-chat-exporter.dist

@JohnRTitor JohnRTitor merged commit a55f190 into NixOS:master Jan 27, 2025
26 of 28 checks passed
@EstebanMacanek EstebanMacanek deleted the fix-whatsapp-chat-exporter branch January 27, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants