-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wa-crypt-tools: init at 0.1.0 #375361
Open
EstebanMacanek
wants to merge
2
commits into
NixOS:master
Choose a base branch
from
EstebanMacanek:add-wa-crypt-tools
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
wa-crypt-tools: init at 0.1.0 #375361
+52
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
10.rebuild-darwin: 1
10.rebuild-darwin: 1-10
10.rebuild-linux: 1
10.rebuild-linux: 1-10
labels
Jan 20, 2025
EstebanMacanek
force-pushed
the
add-wa-crypt-tools
branch
2 times, most recently
from
January 20, 2025 21:12
195da8d
to
488a99f
Compare
ethancedwards8
suggested changes
Jan 20, 2025
Comment on lines
12
to
17
src = fetchPypi { | ||
inherit pname version; | ||
sha256 = "sha256-E/k2lKxlBxUDnfbeELHBi3sML3T+BQJ3zPHh4hGviJ4="; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer fetchFromGitHub
nativeBuildInputs = [ python3Packages.setuptools-scm ]; | ||
|
||
pythonRelaxDeps = [ "protobuf" ]; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add any tests?
|
EstebanMacanek
force-pushed
the
add-wa-crypt-tools
branch
5 times, most recently
from
January 22, 2025 10:55
3b6110b
to
e38950a
Compare
EstebanMacanek
force-pushed
the
add-wa-crypt-tools
branch
2 times, most recently
from
January 25, 2025 20:28
38435c9
to
1bf1dfd
Compare
ethancedwards8
approved these changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add wa-crypt-tools to nixpkgs.
Manage WhatsApp .crypt12, .crypt14 and .crypt15 files.
https://github.com/ElDavoo/wa-crypt-tools
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.