Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wa-crypt-tools: init at 0.1.0 #375361

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

EstebanMacanek
Copy link

@EstebanMacanek EstebanMacanek commented Jan 20, 2025

Add wa-crypt-tools to nixpkgs.
Manage WhatsApp .crypt12, .crypt14 and .crypt15 files.
https://github.com/ElDavoo/wa-crypt-tools

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Comment on lines 12 to 17
src = fetchPypi {
inherit pname version;
sha256 = "sha256-E/k2lKxlBxUDnfbeELHBi3sML3T+BQJ3zPHh4hGviJ4=";
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer fetchFromGitHub

nativeBuildInputs = [ python3Packages.setuptools-scm ];

pythonRelaxDeps = [ "protobuf" ];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add any tests?

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 375361


aarch64-darwin

✅ 2 packages built:
  • wa-crypt-tools
  • wa-crypt-tools.dist

@EstebanMacanek EstebanMacanek force-pushed the add-wa-crypt-tools branch 5 times, most recently from 3b6110b to e38950a Compare January 22, 2025 10:55
@EstebanMacanek EstebanMacanek force-pushed the add-wa-crypt-tools branch 2 times, most recently from 38435c9 to 1bf1dfd Compare January 25, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants