-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gokapi: init at 1.9.6 #372911
base: master
Are you sure you want to change the base?
gokapi: init at 1.9.6 #372911
Conversation
e2e4823
to
2a662f7
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/5071 |
2a662f7
to
f049d26
Compare
Thank you for the review. All of your suggestions taken and implemented, did so locally to keep the commit history to two clean commits. |
f049d26
to
4aa7281
Compare
|
|
Oh, good job on catching that, thank you. The output of Or perhaps mark it as only available for linux? |
That may be best. I'm not sure. |
4aa7281
to
3c2b3e9
Compare
I have now specified
|
Add gokapi, a convenient service for generating links to file downloads.
Adds package derivation, module, and tests.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.