Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/hyperv-guest: drop fb_hyperv in favor of drm_hyperv #372743

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

K900
Copy link
Contributor

@K900 K900 commented Jan 10, 2025

Fixes #372703.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900 K900 requested review from alyssais and Ma27 January 10, 2025 20:37
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: kernel The Linux kernel 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 10, 2025
@K900
Copy link
Contributor Author

K900 commented Jan 10, 2025

Can confirm this allows my Hyper-V VMs to run Wayland just fine.

@me-and
Copy link
Contributor

me-and commented Jan 10, 2025

Testing now, although rebuilding the kernel means getting the new image is taking a while. Given it's my work machine that I'm using Hyper-V on, it might not be until Monday that I can confirm the fix works for me.

@K900
Copy link
Contributor Author

K900 commented Jan 10, 2025

You can just blacklist hyperv_fb instead, it should have the same effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 5001+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plasma6 on Hyper-V is broken by switch to Wayland
2 participants