[Backport release-24.11] haskellPackages.lukko: fix ofd locking on 32bit Linux platforms #372642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nix-backports[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
Quoting the patch: > Previously, OFD locking was broken on 32-bit, because it would somehow > end up using the 64-bit fcntl() function, but pass it 32-bit off_t > values in struct flock. To fix this, tell libc to use always use > 64-bit file offsets. > > This is the same fix that was applied for a similar issue in GHC. (cherry picked from commit 4ba7115)
13 tasks
Jayman2000
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 372642
x86_64-linux
⏩ 1 package marked as broken and skipped:
- stack2nix
✅ 20 packages built:
- cabal-install
- cachix (cachix.bin ,cachix.doc)
- changelog-d
- devenv
- haskell-ci
- hci
- hercules-ci-agent
- pre-commit
- pre-commit.dist
- python311Packages.asteroid-filterbanks
- python311Packages.asteroid-filterbanks.dist
- python311Packages.pyannote-audio
- python311Packages.pyannote-audio.dist
- python312Packages.asteroid-filterbanks
- python312Packages.asteroid-filterbanks.dist
- python312Packages.pyannote-audio
- python312Packages.pyannote-audio.dist
- stack
- whisper-ctranslate2
- whisper-ctranslate2.dist
I also tried to get nixpkgs-review to build packages for i686-linux, but it didn’t work. As a workaround, I manually ran nix-build -A pkgsi686Linux.haskellPackages.hackage-security, and it built successfully.
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #372218.