Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stumpwm: 22.11 -> 24.11 + moved outside lisp-modules #372466

Merged
merged 1 commit into from
Jan 10, 2025
Merged

stumpwm: 22.11 -> 24.11 + moved outside lisp-modules #372466

merged 1 commit into from
Jan 10, 2025
+57 −42

Conversation

Uthar
Copy link
Contributor

@Uthar Uthar commented Jan 9, 2025 •
edited
Loading

Moved outside lisp-modules to a separate package, so as to re-use its Makefile-based build-system and make a step in the direction of leaving just development libraries in lisp-modules.

Continuing discussion from: link

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 9, 2025
@nix-owners nix-owners bot requested review from hraban, 7c6f434c, lukego and nagy January 9, 2025 20:02
@Uthar
stumpwm: 22.11 -> 24.11
ecbc3c2 
Moved outside lisp-modules to a separate package, so as to re-use its
Makefile-based build-system and make a step in the direction of leaving just
development libraries in lisp-modules.
@Uthar Uthar requested a review from 7c6f434c January 10, 2025 03:51
@7c6f434c 7c6f434c merged commit d624c58 into NixOS:master Jan 10, 2025
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hraban hraban Awaiting requested review from hraban

@lukego lukego Awaiting requested review from lukego

@nagy nagy Awaiting requested review from nagy

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uthar @7c6f434c