workflows/eval: add swapfile to tackle recent borderline OOM #371203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: policy discussion
6.topic: continuous integration
nix-owners
bot
requested review from
risicle,
LeSuisse,
zowoq,
mweinelt and
azuwis
github-actions
bot
added
10.rebuild-darwin: 0
JohnRTitor
changed the title
|
Seems to work just fine. |
Note that 2 of the 3 links / comments are not really relevant OOM cases. One of them was not OOM at all and mine was a broken PR, causing huge memory usage, not related to the CI job. |
wolfgangwalther
approved these changes
Jan 5, 2025
infinisil
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed in #356023 (comment).
After some discussion on Matrix with @infinisil, we think its best to just add swapfile back.
Due to recent issues where eval failing due to out of memory #355847 (comment) #355847 (comment) #355847 (comment)