pcmciaUtils: Fix udev rule path #370912
Merged
pcmciaUtils: Fix udev rule path #370912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pcmciaUtils udev rules failed to apply, as some paths were not
replaced correctly. For example, the following udev line is in the
source package:
SUBSYSTEM=="pcmcia", ENV{MODALIAS}=="?*", \
RUN+="__UDEVHELPERDIR__/pcmcia-check-broken-cis"
The Makefile by default replaces the `__UDEVHELPERDIR__` with
`${prefix}/lib/udev`, which is the wrong place on NixOS. To quickly set
the correct path, just replace this placeholder string directly. With
this patch, the udev rules can be applied, as it is done with
`hardware.pcmcia.enable`. The files are referenced correctly and pcmcia
works fine on real hardware.
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
drupol
approved these changes
Jan 5, 2025
|
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pcmciaUtils udev rules failed to apply, as some paths were not replaced correctly. For example, the following udev line is in the source package:
The Makefile by default replaces the
__UDEVHELPERDIR__with${prefix}/lib/udev, which is the wrong place on NixOS. To quickly set the correct path, just replace this placeholder string directly. With this patch, the udev rules can be applied, as it is done withhardware.pcmcia.enable. The files are referenced correctly and pcmcia works fine on real hardware.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.