Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] nixos/prometheus-exporters/fastly: fix secret handling #370903

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

nix-backports[bot]
Copy link

@nix-backports nix-backports bot commented Jan 4, 2025

Bot-based backport to release-24.11, triggered by a label in #370898.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

The exporter expects the token as an environment variable, not a path
to the file containing the token.

(cherry picked from commit 62f35da)
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 4, 2025
@mweinelt
Copy link
Member

mweinelt commented Jan 4, 2025

This is a breaking change, but the situation is broken anyway.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jan 4, 2025
@mweinelt mweinelt merged commit 3640a30 into release-24.11 Jan 4, 2025
19 checks passed
@mweinelt mweinelt deleted the backport-370898-to-release-24.11 branch January 4, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant