Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport staging-24.11] libuv and Node.js changes #368368

Open
wants to merge 6 commits into
base: staging-24.11
Choose a base branch
from
Open

[backport staging-24.11] libuv and Node.js changes #368368

wants to merge 6 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Dec 26, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aduh95 aduh95 force-pushed the nodejs-backports-24.11 branch from 6ad9a55 to f656220 Compare December 26, 2024 16:30
@aduh95 aduh95 changed the title [24.11 backports] Node.js changes [backport staging-24.11] libuv and Node.js changes Dec 26, 2024
@aduh95 aduh95 mentioned this pull request Dec 26, 2024
Closed
13 tasks
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Dec 26, 2024
@ofborg ofborg bot requested a review from np December 26, 2024 21:44
paparodeo
paparodeo suggested changes Dec 26, 2024
View reviewed changes
Copy link
Contributor

@paparodeo paparodeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change f91efef should be dropped as it will break x64 darwin on 24.11 (x64 darwin sdk was bumped to 11 on master but remains at 10.12 on 24.11)

[edit] the change has been dropped from this PR so all good here.

@mweinelt mweinelt marked this pull request as draft December 31, 2024 14:26
@aduh95 aduh95 mentioned this pull request Jan 5, 2025
Merged
13 tasks
@aduh95 aduh95 force-pushed the nodejs-backports-24.11 branch from f656220 to c029740 Compare January 6, 2025 15:55
@aduh95 aduh95 marked this pull request as ready for review January 7, 2025 08:40
r-ryantm and others added 6 commits January 7, 2025 10:15
@r-ryantm @aduh95
libuv: 1.48.0 -> 1.49.2
3d029ba 
(cherry picked from commit a1c1180)
@aduh95
Revert "nodejs_22: fix build with libuv 1.48.0"
f155109 
This reverts commit f1f3028.
@wegank @aduh95
nodejs_23: drop reverts
f15d40f 
(cherry picked from commit 982e3fc)
@paparodeo @aduh95
libuv: disable flaky darwin test
9c676be 
test fails on darwin sometimes

(cherry picked from commit c247ef1)
@paparodeo @aduh95
libuv: remove redundant conditionally disabled tests
5e20820 
remove conditionally disabled tests if they are already disabled by
default.

(cherry picked from commit 69dd998)
@aduh95
nodejs_22: use shared SQLite
8682207 
(cherry picked from commit 5ec3e7b)
@aduh95 aduh95 force-pushed the nodejs-backports-24.11 branch from c029740 to 8682207 Compare January 7, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paparodeo paparodeo paparodeo requested changes

@np np Awaiting requested review from np

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aduh95 @paparodeo @r-ryantm @wegank