vimPlugins: remove explicit nvimRequireCheck #367801
Open
+200
−149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
force-pushed
the
remove-require
branch
2 times, most recently
from
fd985f9 to
dc073eb
Compare
khaneliman
force-pushed
the
remove-require
branch
2 times, most recently
from
4b6ae23 to
a4a0fba
Compare
github-actions
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
khaneliman
force-pushed
the
remove-require
branch
from
a4a0fba to
755ea87
Compare
nix-owners
bot
requested review from
mrcjkb,
rvolosatovs,
PerchunPak,
figsoda,
manveru and
GaetanLepage
khaneliman
force-pushed
the
remove-require
branch
from
755ea87 to
87fe710
Compare
|
Added a couple checkInputs discovered when testing with fix from #372551 |
wegank
added
12.approved-by: package-maintainer
PerchunPak
reviewed
Jan 11, 2025
| }; | ||
|
|
||
| cmd-parser-nvim = super.cmd-parser-nvim.overrideAttrs { | ||
| # Has cmd-parser.init.test matched from lua/cmd-parser/init.test.lua |
There was a problem hiding this comment.
Maybe ignore all files that end in .test.lua? (Not a requirement, just a suggestion)
There was a problem hiding this comment.
Yeah, I'll do another Pr for that targeting staging.
|
khaneliman
force-pushed
the
remove-require
branch
from
87fe710 to
643fa73
Compare
khaneliman
force-pushed
the
remove-require
branch
from
643fa73 to
17c2e8d
Compare
|
Aider-nvim dependency failing on darwin: vvenc> Running phase: fixupPhase
vvenc> Moving /nix/store/s3m2alqkjgan2hfrb2z9xkb1zywy9flm-vvenc-1.13.0-lib/lib/pkgconfig to /nix/store/5s3009rvkqlkn801hq8hw6jykfh0cr14-vvenc-1.13.0-dev/lib/pkgconfig
vvenc> Moving /nix/store/s3m2alqkjgan2hfrb2z9xkb1zywy9flm-vvenc-1.13.0-lib/lib/cmake to /nix/store/5s3009rvkqlkn801hq8hw6jykfh0cr14-vvenc-1.13.0-dev/lib/cmake
vvenc> Patching '/nix/store/5s3009rvkqlkn801hq8hw6jykfh0cr14-vvenc-1.13.0-dev/lib/pkgconfig/libvvenc.pc' includedir to output /nix/store/5s3009rvkqlkn801hq8hw6jykfh0cr14-vvenc-1.13.0-dev
vvenc> checking for references to /private/tmp/nix-build-vvenc-1.13.0.drv-0/ in /nix/store/6syzpsljvr3x13b239776xnm3l40a5lc-vvenc-1.13.0...
vvenc> patching script interpreter paths in /nix/store/6syzpsljvr3x13b239776xnm3l40a5lc-vvenc-1.13.0
vvenc> stripping (with command strip and flags -S) in /nix/store/6syzpsljvr3x13b239776xnm3l40a5lc-vvenc-1.13.0/bin
vvenc> checking for references to /private/tmp/nix-build-vvenc-1.13.0.drv-0/ in /nix/store/s3m2alqkjgan2hfrb2z9xkb1zywy9flm-vvenc-1.13.0-lib...
vvenc> patching script interpreter paths in /nix/store/s3m2alqkjgan2hfrb2z9xkb1zywy9flm-vvenc-1.13.0-lib
vvenc> stripping (with command strip and flags -S) in /nix/store/s3m2alqkjgan2hfrb2z9xkb1zywy9flm-vvenc-1.13.0-lib/lib
vvenc> checking for references to /private/tmp/nix-build-vvenc-1.13.0.drv-0/ in /nix/store/5s3009rvkqlkn801hq8hw6jykfh0cr14-vvenc-1.13.0-dev...
vvenc> patching script interpreter paths in /nix/store/5s3009rvkqlkn801hq8hw6jykfh0cr14-vvenc-1.13.0-dev
vvenc> stripping (with command strip and flags -S) in /nix/store/5s3009rvkqlkn801hq8hw6jykfh0cr14-vvenc-1.13.0-dev/lib
error: cycle detected in build of '/nix/store/cvsa1c75253sassaqb8dv0mx7sq0gnnp-vvenc-1.13.0.drv' in the references of output 'lib' from output 'out' |
khaneliman
force-pushed
the
remove-require
branch
from
17c2e8d to
8507b4b
Compare
Update missing dependencies and let auto require work.
khaneliman
force-pushed
the
remove-require
branch
from
8507b4b to
3125697
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Going through pre-existing nvimRequireChecks and cleaning up the ones that don't need to be explicitly enabled.
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.