[Backport release-24.11] arpack: add ISO C binding and top arpack-mpi attribute #367463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nix-backports[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
13 tasks
|
don't backport this yet -- it breaks darwin. it seems to add single precision api which Accelerate doesn't like so darwin needs to link with openblas. |
will need to backport this PR #367594 for darwin |
use ninja, cmakeBool and remove unneeded install_name_tool usage in postFixup as the library name is already properly set by the build (cherry picked from commit 00baa26)
The arpack package included the eigen library and added it to the build inputs but neglected to enable its use by setting `EIGEN=ON` in the build flags. Enable support for eigenvalue-problems solver based on ICB and eigen and disable parallel checking as the tests fail when run in parallel. (cherry picked from commit 89e9ea2)
Copy darwin flags `-ff2c -fno-second-underscore` from workflow to use Accelerate without segfaulting / failing tests and enable the Accelerate framework when `useAccel` is true. https://github.com/opencollab/arpack-ng/blob/804fa3149a0f773064198a8e883bd021832157ca/.github/workflows/jobs.yml#L184-L192 (cherry picked from commit 2f215b7)
Cherry-picked the 4 commits from there in here as well. |
|
|
aarch64-darwin build fails with: |
womp womp. linking with flat_namespace exposes a bug somewhere in our stack. this would fix it #370526 as would removing or adding |
|
oh -- this is only the |
Ah, mh. Maybe that package should be renamed then, because I got the error as something like this: |
|
k. will fix the linker error too and send the PR to master. [edit] tho tests seem to be failing so maybe not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #357259.