Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dtbloader: init at 1.2.2 #365174

Merged
merged 1 commit into from
Jan 3, 2025
Merged

dtbloader: init at 1.2.2 #365174

merged 1 commit into from
Jan 3, 2025

Conversation

liberodark
Copy link
Contributor

@liberodark liberodark commented Dec 14, 2024 •
edited
Loading

Fix : #365172
Help : kuruczgy/x1e-nixos-config#45

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 14, 2024
@liberodark liberodark force-pushed the dtbloader branch 3 times, most recently from 771dd8b to eb760b0 Compare December 14, 2024 13:25
@kuruczgy
Copy link
Contributor

Thoughts:

  • Packaging dtbloader is probably the easy part, I think people would also want to see some PoC of how this is integrated with the ISO and the installed system.
  • We should be aware that dtbloader is not the final solution to the problem, and hopefully something better will come along in the future. (See this blog post: https://samuel.dionne-riel.com/blog/2024/12/05/dtb-loading-is-harder-than-it-looks.html ) So even if we integrate it, it should be easy to add other solutions too, and we should be ready to rip out dtbloader support once we have something better.

@liberodark
Copy link
Contributor Author

This packaging is simply to help have a better aarch64 laptop support.
Feel free to test it, put it on your isos and give me your feedback.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1 labels Dec 15, 2024
@ifurther
Copy link
Contributor

The efi file only for aarch64 paltform, so the paltform should drop the x86-64.

@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Dec 17, 2024
@liberodark liberodark force-pushed the dtbloader branch 2 times, most recently from dc379ad to e3055a7 Compare December 24, 2024 07:11
@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 24, 2024
@ofborg ofborg bot added 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux and removed 10.rebuild-linux: 1-10 labels Dec 24, 2024
@liberodark
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365174

aarch64-linux

✅ 1 package built:
  • dtbloader

GaetanLepage
GaetanLepage requested changes Jan 3, 2025
View reviewed changes
pkgs/by-name/dt/dtbloader/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/dt/dtbloader/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/dt/dtbloader/package.nix Show resolved Hide resolved
@liberodark liberodark force-pushed the dtbloader branch 4 times, most recently from 397da94 to 19cf4ee Compare January 3, 2025 12:54
GaetanLepage
GaetanLepage approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@GaetanLepage
Copy link
Contributor

@ofborg build dtbloader

@github-actions github-actions bot added 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 3, 2025
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365174

@liberodark
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365174

x86_64-linux

aarch64-linux

✅ 1 package built:
  • dtbloader

x86_64-darwin

aarch64-darwin

@GaetanLepage GaetanLepage added the backport release-24.11 Backport PR automatically label Jan 3, 2025
@GaetanLepage GaetanLepage merged commit f010ae5 into NixOS:master Jan 3, 2025
23 of 24 checks passed
@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Jan 3, 2025
Merged
1 task
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 3, 2025

Successfully created backport PR for release-24.11:

kuruczgy
kuruczgy suggested changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@kuruczgy kuruczgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would still like to signal that I want to see an example use-case for this. How is anyone supposed to test this package?

pkgs/by-name/dt/dtbloader/package.nix
hardeningDisable = [ "all" ];

buildPhase = ''
make -j$NIX_BUILD_CORES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is an explicit buildPhase necessary? If you want parallel builds, just use enableParallelBuilding = true;.

pkgs/by-name/dt/dtbloader/package.nix Show resolved Hide resolved
@GaetanLepage
Copy link
Contributor

Thanks for the feedback @kuruczgy. It is addressed in #370647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@kuruczgy kuruczgy kuruczgy requested changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package request: dtbloader
4 participants
@liberodark @kuruczgy @ifurther @GaetanLepage