onnxruntime: 1.18.1 -> 1.20.1; eigen: 3.4.0 -> 3.4.0-unstable-2022-05-19 #364362
+326
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wegank
added
the
2.status: merge conflict
mweinelt
force-pushed
the
onnxruntime-1.20.1
branch
from
0e0ce49 to
21730fa
Compare
mweinelt
removed
the
2.status: merge conflict
mweinelt
force-pushed
the
onnxruntime-1.20.1
branch
from
21730fa to
8af8086
Compare
mweinelt
force-pushed
the
onnxruntime-1.20.1
branch
from
8af8086 to
2123ea3
Compare
13 tasks
mweinelt
force-pushed
the
onnxruntime-1.20.1
branch
2 times, most recently
from
6ac8ba2 to
ebf9826
Compare
There was a problem hiding this comment.
Is this https://github.com/NVIDIA/cudnn-frontend/blob/ee971b18ee428ff55b444ac93876cfbd377d304f/CMakeLists.txt? Why do we have to vendor it, and if we do how do we appropriately attribute it
CC @ConnorBaker
Comment on lines
+72
to
+75
| substituteInPlace include/cudnn_frontend_utils.h \ | ||
| --replace-fail \ | ||
| '#include "cudnn_frontend/thirdparty/nlohmann/json.hpp"' \ | ||
| '#include <nlohmann/json.hpp>' |
There was a problem hiding this comment.
Note for future: perhaps we could patch upstream's target_include_directories&c stanza make the latter work even when they vendor thirdparty?
Comment on lines
+112
to
+116
| if [[ -e "$out/bin" ]] | ||
| then | ||
| nixErrorLog "The bin directory in \$out should no longer exist." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
What should be the contents of $out? It's not bin/ and not python bindings. Cmake modules?
Fast forward to a version required by onnxruntime.
Fails to find protoc during cmake configure phase.
mweinelt
force-pushed
the
onnxruntime-1.20.1
branch
from
ebf9826 to
e843b10
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/microsoft/onnxruntime/releases/tag/v1.19.0
https://github.com/microsoft/onnxruntime/releases/tag/v1.19.2
https://github.com/microsoft/onnxruntime/releases/tag/v1.20.0
https://github.com/microsoft/onnxruntime/releases/tag/v1.20.1
Things done
cudaSupport)nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.