recaf: init at 2.21.14, recaf_4: init at 4.0-unstable-2024-11-03 #354184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: package (new)
|
looks like it got a merge conflict :( |
What are the odds that someone just happens to add an entry to all-packages.nix at the exact same spot that I did... EDIT: Nevermind, appears to be something caught up by the by-name migration |
pluiedev
force-pushed
the
init/recaf
branch
4 times, most recently
from
8497fba to
6ea2d8a
Compare
|
Duplicate of #350589? |
That one doesn't package recaf 2.x though, which is still technically the stable release branch |
13 tasks
|
Result of 2 packages failed to build:
|
Both builds still succeed for me 🤷🏼♀️ Can you send me the logs where it failed? |
here ya go |
|
|
That's really odd. Lemme try to update to the latest commit for Recaf 4 though I have absolutely zero idea why the tests are failing for Recaf 2 |
|
I decided to just update to a slightly newer commit for Recaf 4 and disable the failing tests for Recaf 2 |
|
|
What's the status of this? |
Comment on lines
+22
to
+23
| # Needed for automatic version detection - build script will fail without it | ||
| leaveDotGit = true; |
There was a problem hiding this comment.
Would be better to patch the build script
There was a problem hiding this comment.
It's uhm... Not trivial. I actually tried going that route, but the way it works is that it generates a Java source file containing version metadata and it's not easy to call that generator outside of Gradle. If someone wants to tackle this, they can, but this is outside my paygrade
Very confused as to why the builds are working for me but not for other people |
getchoo
reviewed
Dec 8, 2024
|
@ofborg build recaf recaf_4 |
wegank
added
the
12.approvals: 1
wegank
removed
the
12.approvals: 1
|
|
||
| nativeBuildInputs = [ makeBinaryWrapper ]; | ||
|
|
||
| mvnHash = "sha256-MPPZXQilmMaj8n5SXP7fG1Q95pH5Ydu7jU+KRS9beO8="; |
There was a problem hiding this comment.
Suggested change
| mvnHash = "sha256-MPPZXQilmMaj8n5SXP7fG1Q95pH5Ydu7jU+KRS9beO8="; | |
| mvnHash = "sha256-QwkUgTF/a0ZY2RN8fvlVBsMECo9ijUCRB7nuW7zIt/Y="; |
on x64 Linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #267124
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.