Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arouteserver: init at 1.23.1 #353218

Merged
merged 2 commits into from
Nov 4, 2024
Merged

arouteserver: init at 1.23.1 #353218

merged 2 commits into from
Nov 4, 2024

Conversation

MarcelCoding
Copy link
Member

@MarcelCoding MarcelCoding commented Nov 2, 2024 •
edited
Loading

Things done

This PR is already productive deployed at DD-IX.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@MarcelCoding MarcelCoding force-pushed the arouteserver branch 6 times, most recently from 8dc09fb to afe0465 Compare November 3, 2024 00:06
@MarcelCoding MarcelCoding marked this pull request as ready for review November 3, 2024 00:12
@nix-owners nix-owners bot requested a review from natsukium November 3, 2024 00:14
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 3, 2024
SuperSandro2000
SuperSandro2000 requested changes Nov 3, 2024
View reviewed changes
pkgs/by-name/ar/arouteserver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ar/arouteserver/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ar/arouteserver/package.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/aggregate6/default.nix Outdated Show resolved Hide resolved
pkgs/by-name/ar/arouteserver/package.nix Show resolved Hide resolved
pkgs/by-name/ar/arouteserver/package.nix Outdated Show resolved Hide resolved
@johannwagner
Copy link
Contributor

johannwagner commented Nov 3, 2024 •
edited
Loading

@wdzgmbh agrees to maintain this 🙌
We are currently using this in production, but using the packaging in our repo.

@SuperSandro2000 SuperSandro2000 merged commit 14e770e into NixOS:master Nov 4, 2024
26 of 28 checks passed
@MarcelCoding MarcelCoding deleted the arouteserver branch November 4, 2024 09:52
@vcunat
Copy link
Member

vcunat commented Jan 6, 2025 

=========================== short test summary info ============================
FAILED Copyright: is current year - AssertionError: 2024 != 2025 : Consider to run ./utils/apply_copyright
============ 1 failed, 263 passed, 25 warnings in 90.98s (0:01:30) =============

Excellent tests.

@MarcelCoding
Copy link
Member Author

... There is already a new version out. I did not do the update myself and wanted to wait for the bot, but I guess this is not the case.

@vcunat
Copy link
Member

vcunat commented Jan 6, 2025 •
edited
Loading

Regardless of updates, tests running in nixpkgs shouldn't do such checks. They do only harm here (spurious failures). In upstream CI perhaps but nowhere else.

@MarcelCoding
Copy link
Member Author

I'll work out a fix to disable specific tests.

@MarcelCoding MarcelCoding mentioned this pull request Jan 6, 2025
Merged
13 tasks
@MarcelCoding
Copy link
Member Author

I've created #371416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@natsukium natsukium Awaiting requested review from natsukium

@johannwagner johannwagner Awaiting requested review from johannwagner

@yu-re-ka yu-re-ka Awaiting requested review from yu-re-ka

@n0emis n0emis Awaiting requested review from n0emis

@vidister vidister Awaiting requested review from vidister

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcelCoding @johannwagner @vcunat @SuperSandro2000