Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: use gitMinimal instead of git, to avoid perl in runtime closure #345910

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

WilliButz
Copy link
Member

This change allows docker to be used on systems with the perlless profile, previously perl was pulled into the runtime closure via git when docker was enabled.
I did not find any reason for why docker would require git with PCRE support.

originally added in 08d83c1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Result of nixpkgs-review run on x86_64-linux 1

15 packages built:
  • airlift
  • airlift.dist
  • charliecloud
  • devcontainer
  • docker
  • docker-gc
  • docker-sbom
  • docker_25
  • docker_26
  • fn-cli
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist

cc: #265640 (perlless efforts)

@WilliButz WilliButz marked this pull request as ready for review October 2, 2024 11:03
@WilliButz
Copy link
Member Author

@ofborg test docker

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@drupol drupol merged commit 2c8ffbf into NixOS:master Oct 2, 2024
33 checks passed
@WilliButz WilliButz deleted the docker/perlless-gitMinimal branch October 3, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants