Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantheon.gala: Fix window placement in MultiTaskingView #315137

Merged
merged 1 commit into from
May 28, 2024
Merged

pantheon.gala: Fix window placement in MultiTaskingView #315137

merged 1 commit into from
May 28, 2024

Conversation

bobby285271
Copy link
Member

@bobby285271 bobby285271 commented May 27, 2024 •
edited
Loading

It looks like the fix is very related to the GLib 2.76 bump, landing ahead of #312449.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@bobby285271
pantheon.gala: Fix window placement in MultiTaskingView
42f4ab2 
It looks like the fix is very related to the GLib 2.76 bump.
@github-actions github-actions bot added the 6.topic: pantheon The Pantheon desktop environment label May 27, 2024
@bobby285271
Copy link
Member Author

@ofborg test pantheon

@ofborg ofborg bot requested a review from davidak May 27, 2024 19:11
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels May 27, 2024
@bobby285271 bobby285271 merged commit 6aafa50 into NixOS:master May 28, 2024
33 checks passed
@bobby285271 bobby285271 deleted the upd/gala branch May 28, 2024 10:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 9, 2024

Successfully created backport PR for release-24.05:

@github-actions github-actions bot mentioned this pull request Jun 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak Awaiting requested review from davidak

Assignees
No one assigned
Labels
6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bobby285271