-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/goldwarden: init, goldwarden: package GUI #293117
Conversation
6afca3a
to
00ce96f
Compare
The correct way is to use goldwarden through the programs.goldwarden module and the correct pinentry flavor based on programs.gnupg.agent.pinentryFlavor is now used.
00ce96f
to
13f0edd
Compare
13f0edd
to
8d40fb5
Compare
8d40fb5
to
8d27855
Compare
I'm running into an issue with the systemd service not having pinentry in PATH. Works fine when I run goldwarden daemonize manually though.
Adding this to the systemd service fixed it. path = [ config.programs.gnupg.agent.pinentryPackage ]; |
…ive extension files
7523b61
to
9f9409f
Compare
9f9409f
to
5878406
Compare
5878406
to
7ffcd69
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. If possible, can you add a simple test just to check if there are any breaking changes in the service?
Goldwarden is sometimes a bit brittle and fails for no apparent reason. Also we would need a running vaultwarden and probably create some entries in it which is a bit more involved. |
On the GUI side, quexten/goldwarden#191 should fix a lot of the issues regarding stability. The daemon still needs some work, if you do encounter further issues please try to report them though, so they can be fixed :) |
Description of changes
Things done:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.