Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/goldwarden: init, goldwarden: package GUI #293117

Merged
merged 4 commits into from
Mar 27, 2024

Conversation

SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented Mar 4, 2024

Description of changes

Things done:

  • packaged GUI
  • made a module which installs polkit files, pinentry
  • tested ssh agent functionality
  • tested browser functionality

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 4, 2024
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 4, 2024
@ofborg ofborg bot requested a review from arthsmn March 4, 2024 00:28
The correct way is to use goldwarden through the programs.goldwarden module
and the correct pinentry flavor based on programs.gnupg.agent.pinentryFlavor is now used.
nixos/modules/programs/goldwarden.nix Outdated Show resolved Hide resolved
nixos/modules/programs/goldwarden.nix Show resolved Hide resolved
nixos/modules/programs/goldwarden.nix Show resolved Hide resolved
@Kasper24
Copy link
Contributor

Kasper24 commented Mar 21, 2024

I'm running into an issue with the systemd service not having pinentry in PATH. Works fine when I run goldwarden daemonize manually though.

Error: exec: "pinentry": executable file not found in $PATH

Adding this to the systemd service fixed it.

path = [ config.programs.gnupg.agent.pinentryPackage ];

@SuperSandro2000 SuperSandro2000 force-pushed the goldwarden branch 2 times, most recently from 7523b61 to 9f9409f Compare March 24, 2024 18:39
@ofborg ofborg bot requested a review from arthsmn March 24, 2024 19:23
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review March 24, 2024 20:40
@ofborg ofborg bot requested a review from arthsmn March 24, 2024 21:04
nixos/modules/programs/goldwarden.nix Outdated Show resolved Hide resolved
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Mar 24, 2024
@quexten quexten mentioned this pull request Mar 25, 2024
13 tasks
Copy link
Member

@arthsmn arthsmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If possible, can you add a simple test just to check if there are any breaking changes in the service?

@SuperSandro2000
Copy link
Member Author

Goldwarden is sometimes a bit brittle and fails for no apparent reason. Also we would need a running vaultwarden and probably create some entries in it which is a bit more involved.

@SuperSandro2000 SuperSandro2000 merged commit 9b1984c into NixOS:master Mar 27, 2024
24 checks passed
@SuperSandro2000 SuperSandro2000 deleted the goldwarden branch March 27, 2024 16:04
@quexten
Copy link

quexten commented May 3, 2024

Goldwarden is sometimes a bit brittle and fails for no apparent reason. Also we would need a running vaultwarden and probably create some entries in it which is a bit more involved.

@SuperSandro2000

On the GUI side, quexten/goldwarden#191 should fix a lot of the issues regarding stability. The daemon still needs some work, if you do encounter further issues please try to report them though, so they can be fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants