spoof: init at 2.0.4

[milomg]

Description of changes

https://github.com/feross/spoof (Feross' updated version of https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/networking/spoof-mac/default.nix)

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[applePrincess]

Result of nixpkgs-review pr 285855 run on x86_64-linux 1

1 package built:

• spoof

[raspher]

lgtm, see no evil, but there is a catch... spoof list does not list any interfaces, does this work for you? What are the results when you test it via nixpkgs-review?

Logs are long, i show ip a and ifconfig are listing interfaces but spoof does not
https://gist.github.com/raspher/ec727925208930e66816256ae5cb58d0

nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.78, NixOS, 23.11 (Tapir), 23.11.4703.c5101e457206`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixos-23.11, nixos-unstable"`
 - nixpkgs: `/home/raspher/.cache/nixpkgs-review/pr-285855-2/nixpkgs`

[milomg]

When testing on Darwin, spoof randomize en0 seemed to work for me, but I can test again with sandboxing.

I wonder if the issue above is related to feross/spoof#41

[milomg]

@raspher Anything else I should do to get this merged?

[h7x4]

@milomg feel free to just ping a committer or something when it takes this much time