vtk_8: remove #255928
Merged
vtk_8: remove #255928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag does not actually cause opencv3 to detect vtk. Instead of fixing it, we remove it to remove the optional dependence on vtk_8. (Note this flag works correctly in opencv4.)
veprbl
reviewed
Sep 18, 2023
bcdarwin
force-pushed
the
remove-vtk_8
branch
from
8ac314b to
b170532
Compare
Needs update and fixed dependencies (nontrivial) to work with recent Python and with opencascade-occt and recent pythonocc-core. (Note the package already didn't build due to the Python 3.8 upper bound.)
Use of `smesh` was removed in version 7.4.0 as per the NEWS file.
No commits to master since 2019, depends on similarly unmaintained opencascade-oce, and mainly used for pythonocc-core package which is similarly unmaintained.
bcdarwin
force-pushed
the
remove-vtk_8
branch
2 times, most recently
from
25fd543 to
590ccba
Compare
|
Results of |
bcdarwin
force-pushed
the
remove-vtk_8
branch
from
590ccba to
3dc2bb5
Compare
bcdarwin
force-pushed
the
remove-vtk_8
branch
from
3dc2bb5 to
f110ccc
Compare
|
Result of 2 packages marked as broken and skipped:
20 packages built:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Somewhat aggressive removal of vtk_8 and depending packages; basically:
mirtkto an unstable version;opencascadesince development seems to have switched back toopencascade-occt(e.g. pythonocc-core and cadquery switched over; see also [question] is this repo still maintained? (seems now to be behind OCCT) tpaviot/oce#745 (comment)) and handle some resulting breakage.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)