Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.sphinxcontrib-openapi: link to upstream PR, add maintainers #189112

Merged
merged 2 commits into from
Aug 31, 2022
Merged

python3.pkgs.sphinxcontrib-openapi: link to upstream PR, add maintainers #189112

merged 2 commits into from
Aug 31, 2022

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Aug 31, 2022

This adds maintainers to the package, and links to the PR sent upstream to switch
from m2r to sphinx-mdinclude .

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

flokli added 2 commits August 31, 2022 15:29
@flokli
python3.pkgs.sphinxcontrib-openapi: link to upstream PR
59f363c 
cilium sent a PR upstream at
sphinx-contrib/openapi#127.

Link to it from here, so we know when to switch away from the fork.
@flokli
python3.pkgs.sphinxcontrib-openapi: add maintainers
66b851c
@flokli flokli requested review from FRidh and jonringer as code owners August 31, 2022 13:37
@flokli flokli mentioned this pull request Aug 31, 2022
Merged
13 tasks
@flokli flokli requested a review from SuperSandro2000 August 31, 2022 13:37
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Aug 31, 2022
@SuperSandro2000 SuperSandro2000 merged commit f05c586 into NixOS:master Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flokli @SuperSandro2000