Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.2.4-rc.1 #58

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Release v0.2.4-rc.1 #58

merged 2 commits into from
Jan 17, 2025

Conversation

robin-nitrokey
Copy link
Member

This release candidate fixes concurrent access to different models and tests trusted publishing to PyPI.

This release candidate fixes concurrent access to different models and
tests trusted publishing to PyPI.
@robin-nitrokey
Copy link
Member Author

Looks like RPM does not like release candidates:

$ rpmspec -q --qf "%{version}" ci-scripts/linux/rpm/python3-nitrokey.spec
error: line 2: Illegal char '-' (0x2d) in: Version:        0.2.4-rc.1
error: query of specfile ci-scripts/linux/rpm/python3-nitrokey.spec failed, can't parse

The spec says:

The version string consists of alphanumeric characters, which can optionally be segmented with the separators ., _ and +, plus ~ and ^ (see below).
Tilde (~) can be used to force sorting lower than base (1.1~201601 < 1.1). Caret (^) can be used to force sorting higher than base (1.1^201601 > 1.1). These are useful for handling pre- and post-release versions, such as 1.0~rc1 and 2.0^a.

@mmerklinger Any objections to mapping vx.y.z-rc.n to x.y.z~rcn?

@robin-nitrokey robin-nitrokey merged commit c2ccf66 into main Jan 17, 2025
38 checks passed
@robin-nitrokey robin-nitrokey deleted the release-v0.2.4-rc.1 branch January 17, 2025 17:28
@robin-nitrokey
Copy link
Member Author

Deployment does not work yet:

  • The workflow is only triggered for released releases, not for prereleased releases.
  • Even when marking the rc as a release, the filter github.event.name == 'release' is not active.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants