Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Tree Style Tab 4.0 and later #38

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

piroor
Copy link
Contributor

@piroor piroor commented Sep 13, 2024

TST 4.0 and later is built on a virtual scrolling implementation and it generates HTML elements only near the viewport, so showing/hiding search results with a CSS hack is not effective anymore. Moreover, the virtual scrolling implementation expects all tab elements have same height, so the "shrink unmatched tabs" option breaks the result.

This PR introduces:

  • Hides tabs marked as "hidden" by browser.tabs.hide().
  • Ignores "shrink" option on TST 4.0 and later.

How about this change?

@inspire22
Copy link

Looks like the dev hasn't been responsive. Any tips how to install from your fork, or is this something built into TST already now?

@piroor
Copy link
Contributor Author

piroor commented Feb 10, 2025

Sadly this is not (and cannot) built into TST itself. You need to clone the branch https://github.com/piroor/tst-search/tree/support-tst-4 to your PC and build it with the web-ext command installed via npm, to try it locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants