fix(gnome): No ellipses on Video Format combobox #1050
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1047
Summary:
GtkHelpers::newNoEllipsesItemFactory()
which creates aGtkListItemFactory
that disables ellipses on every widget in the ListView.helpers/listitemfactory.cpp
which do the work of creating the label for each ListItem.GtkHelpers::setComboRowModel()
and pass the factory intoadw_combo_row_set_factory()
This is the result in the GUI
This works as expected but is a sloppy C solution for a C++ app structure. There's a few things that need to be fixed:
setComboRowModel()
.GtkHelpers
.I'm not very familiar with C++ design so I'd appreciate your opinion on how to reconcile these so it fits neatly into the existing code.