[노철] - 마이페이지 디자인 변경 #278
Merged
[노철] - 마이페이지 디자인 변경 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suehdn
approved these changes
Dec 19, 2023
src/app/(header)/my/page.tsx
Outdated
| ajajaToast.success('닉네임이 변경되었습니다.'); | ||
| }, | ||
| onError: () => { | ||
| ajajaToast.error('닉네임 변경에 실패했습니다. 다시 시도해주세요.'); |
There was a problem hiding this comment.
모바일에서 보여주기엔 좀 긴 문장같습니다. 좀 줄이는게 낫지 않을까요?
There was a problem hiding this comment.
맞아요, 그리고 toast 도 넘쳐서 ㅎㅎ 바꾸겠습니다
src/app/(header)/my/page.tsx
Outdated
| }, | ||
| onError: () => { | ||
| ajajaToast.error( | ||
| '리마인드 방식 변경에 실패했습니다. 다시 시도해주세요', |
|
리마인드 방식 변경할 때 이메일 인증이 되어있지 않다면 이메일 관련 방식은 누르지 못하게 비활성화 하는 게 어떠신가요? |
suehdn
reviewed
Dec 19, 2023
Comment on lines
85
to
87
| <span className="color-origin-primary"> | ||
| 이메일로 리마인드를 받기 위해서는 이메일 인증이 필요합니다. | ||
| </span> |
There was a problem hiding this comment.
문장의 줄바꿈이 좀 이상하게 되는 것 같은데
피그마는 글자 크기가 12px인데 현재 16px으로 되어 있어서 그런 것 같네요
Suggested change
| <span className="color-origin-primary"> | |
| 이메일로 리마인드를 받기 위해서는 이메일 인증이 필요합니다. | |
| </span> | |
| <span className={classNames("color-origin-primary","font-size-xs")}> | |
| 이메일로 리마인드를 받기 위해서는 이메일 인증이 필요합니다. | |
| </span> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 이슈 번호
close #266
🚀 구현 내용