-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 2.6.0 release #534
Conversation
@lawrence-mbf Could you please check if matnwb works OK with the latest schema version here? |
why delete the original schema json document? |
Sorry for not documenting that and thanks for asking! We can archive this and other v1 schema files in a separate repo. Note that a non-json form of v1 schema are cached here: https://github.com/NeurodataWithoutBorders/specification_nwbn_1_0_x . For archival, we could copy all the v1 schema files from the git history into https://github.com/NeurodataWithoutBorders/specification_nwbn_1_0_x. Or we could simply leave users to peruse the git history of that repo. I do not think these files need to be cached in this nwb-schema repo. What do you think? I do not have experience with v1 schema files and am not sure how they would continue to be used if at all. |
As someone still manintaining software reading/writing NWBv1 files, I would think that having an archived and separate repo would be nice and suffice. So just copy them into https://github.com/NeurodataWithoutBorders/specification_nwbn_1_0_x and your done. Thanks! |
Just for clarification, the JSON for NWB 1.x that is stored here is what we had used originally as a starting point for NWB 2. We had generated that file from the https://github.com/NeurodataWithoutBorders/api-python/blob/master/nwb/nwb_core.py. The https://github.com/NeurodataWithoutBorders/specification_nwbn_1_0_x specification repo unfortunately never actually tracked the actual schema, but only contained the documentation that was generated using the https://github.com/NeurodataWithoutBorders/api-python code. The true reference for NWB 1 was really the api-python code and more specifically the Python dict in https://github.com/NeurodataWithoutBorders/api-python/blob/master/nwb/nwb_core.py . NWB 1 didn't actually use JSON for the schema, but the schema was really defined by the dict in the Python file. As such, for NWB 1, https://github.com/NeurodataWithoutBorders/api-python/blob/master/nwb/nwb_core.py should be the reference. I think what we probably should do is to add text to https://github.com/NeurodataWithoutBorders/specification_nwbn_1_0_x/blob/master/README.md to explain that the schema is defined in Long story short, I think removing
Yes, that is because that is the version when we branched off to develop NWB verions 2. Changes in v1.0.5 and v1.0.6 were made after we started working on NWB 2 (but if I remember correctly those were all just very minor changes). |
I added a note in the README about where to find the NWB 1 reference schema (https://github.com/NeurodataWithoutBorders/api-python/blob/master/nwb/nwb_core.py). |
Prepare for release of nwb-schema 2.6.0.
Target release date: January 5, 2023
Before merging:
Legal.txt
,license.txt
,README.md
,docs/format/source/conf.py
,and any other locations as needed
README.rst
as neededdocs/format/source/conf.py
,core/nwb.namespace.yaml
, andcore/nwb.file.yaml
(remove "-alpha" suffix)
docs/format/source/conf.py
as neededdocs/format/source/format_release_notes.rst
and any other docs asneeded
cd docs/format; make fulldoc
) where the nwb-schema submodule in the local version of PyNWBis fully up-to-date with the head of the dev branch.
build docs for new branch): https://readthedocs.org/projects/nwb-schema/builds/
After merging:
git tag [version] --sign
, copy and paste therelease notes into the tag message, and run
git push --tags
.click "..." -> "Create release" for the new tag on the right side of the page.
Copy and paste the release notes into the release message, update the formatting if needed (reST to Markdown),
and set the title to the version string.
merged PR. https://readthedocs.org/projects/nwb-schema/builds/
commit.
See https://nwb-schema.readthedocs.io/en/latest/software_process.html for more details.