Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to deploy website previews for PRs #2

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Nov 19, 2024

No description provided.

Copy link

github-actions bot commented Nov 19, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://NeurodataWithoutBorders.github.io/neurodatawithoutborders.github.io/pr-preview/pr-2/
on branch gh-pages at 2024-11-20 00:12 UTC

@oruebel oruebel closed this Nov 20, 2024
@oruebel oruebel reopened this Nov 20, 2024
@oruebel oruebel closed this Nov 20, 2024
@oruebel oruebel reopened this Nov 20, 2024
@oruebel
Copy link
Contributor Author

oruebel commented Nov 20, 2024

Building the site and running the pr-preview seems to work. However, when going to the preview link it seems to for some reason forward to the main website, which is not what we want.

@oruebel
Copy link
Contributor Author

oruebel commented Nov 20, 2024

The baseURL in the built pages seems to be fine. Maybe there is an issue with the settings for the GitHub pages. Will need to investigate some more.

@oruebel
Copy link
Contributor Author

oruebel commented Jan 16, 2025

@rly @bendichter do you have an idea what the issue may be with this PR. As far as i can tell, everything seems to work but the pr-preview link seems to forward to the main website instead of showing the actual page (but I can't seem to figure out why)

@rly
Copy link
Contributor

rly commented Jan 22, 2025

We use the deploy-pages action to deploy the site. That may not be compatible with this pr-preview action... rossjrw/pr-preview-action#21

@rly
Copy link
Contributor

rly commented Jan 22, 2025

If we continue this path, we may need to update the workflow permissions. It seems the github token may not (or no longer) have permissions to write to a branch / comment on a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants