-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inherited readonly props #560
Fix inherited readonly props #560
Conversation
Some readonly props are inherited from superclasses where the same prop is settable. This will override the validator method for such a property to throw an error if someone tries to set a readonly property
@ehennestad This is not kosher but could you apply the fix mentioned in here: #262 (comment) as most of the errors in these tests come from there. |
The failed test is actually a good sign!
|
Fix test that broke because of current PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #560 +/- ##
==========================================
+ Coverage 88.49% 88.52% +0.02%
==========================================
Files 104 104
Lines 4616 4636 +20
==========================================
+ Hits 4085 4104 +19
- Misses 531 532 +1 ☔ View full report in Codecov by Sentry. |
Only add validator for inherited readonly props Also support boolean read only property values
5396243
into
NeurodataWithoutBorders:master
Motivation
Some schema attributes are redefined to be readonly for inherited classes. In MATLAB a property attribute can not be redefined for subclasses, so it was possible to set readonly properties.
How to test the behavior?
Checklist
fix #XX
whereXX
is the issue number?