Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AnnotationSeries data type #141

Merged
merged 11 commits into from
Jan 21, 2025
Merged

Add AnnotationSeries data type #141

merged 11 commits into from
Jan 21, 2025

Conversation

stephprince
Copy link
Collaborator

Fix #97. These changes:

  • add the AnnotationSeries class
  • add convenience methods for creating an AnnotationSeries dataset and adding annotations to the file
  • add testing for the class and convenience methods

@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 97.43590% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.01%. Comparing base (c2ee9e6) to head (a929d87).

Files with missing lines Patch % Lines
src/nwb/misc/AnnotationSeries.cpp 92.30% 2 Missing ⚠️
src/io/hdf5/HDF5RecordingData.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #141      +/-   ##
==========================================
+ Coverage   91.83%   92.01%   +0.18%     
==========================================
  Files          58       61       +3     
  Lines        3893     4009     +116     
  Branches      256      262       +6     
==========================================
+ Hits         3575     3689     +114     
- Misses        308      310       +2     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephprince stephprince marked this pull request as ready for review January 16, 2025 00:33
@stephprince stephprince requested a review from oruebel January 16, 2025 00:33
@stephprince
Copy link
Collaborator Author

@oruebel this is ready for you to re-review

@stephprince stephprince requested a review from oruebel January 21, 2025 22:47
@stephprince stephprince merged commit d76f8b7 into main Jan 21, 2025
10 checks passed
@stephprince stephprince deleted the add-annotationseries branch January 21, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add AnnotationSeries datatype
3 participants