Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Try not using poetry env #578

Closed
wants to merge 3 commits into from
Closed

Conversation

larsoner
Copy link

From MNE-Python office hours, just a quick one-off idea on how to solve an env problem. Not sure if it'll work but let's try!

Also adds a concurrency to cancel in case multiple pushes are done. Maybe you don't want this but I thought I'd put it in in case you do.

@larsoner
Copy link
Author

Needs a dev approval to run

@bruAristimunha
Copy link
Collaborator

Hi @larsoner,

Sorry for the not related issue. It is fixed now.

@larsoner
Copy link
Author

Can you point me to the failing step in your CIs? I assumed it was with the "Building Docs" step but it looks like that was passing on the latest commit(s) to develop

@bruAristimunha
Copy link
Collaborator

Yes @larsoner! During the deployment step.

We have two deployments on the page, one of which is done manually by moving the entire building to the github repository (https://github.com/NeuroTechX/moabb.github.io). Another one is done directly with GitHub action. Both are not working.

Here:

- name: Deploy on gh-pages
run: |
git config --global user.email "[email protected]"
git config --global user.name "Github Actions"
cd ~/work/moabb/moabb/moabb-ghpages
rm -Rf docs
cp -a ~/work/moabb/moabb/docs/build/html ./docs
git add -A
git commit -m "GH Actions update of GH pages ($GITHUB_RUN_ID - $GITHUB_RUN_NUMBER)"
git push origin gh-pages

@bruAristimunha
Copy link
Collaborator

@larsoner
Copy link
Author

larsoner commented May 1, 2024

A bit tough to work on without the actions running etc. I could open a tiny PR or something but not sure how much time I could spend looking into it at the moment anyway. So in general I'd suggest adding stuff like ls -al etc. in the run and test ... type statements to make sure things are where you think they are. That plus commenting out some code (like I did in the latest commit commenting out an if: ) to make sure the steps actually run in a PR can be helpful. In theory as long as you open a PR from a fork (rather than a branch) it shouldn't actually push, but in practice I usually comment out whatever could do damage (like git push origin gh-pages) to be safe. Good luck!

@larsoner larsoner closed this May 1, 2024
bruAristimunha added a commit to PierreGtch/moabb that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants