Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NeoMatlabIO write_block unused kargs #1638

Merged

Conversation

TommasoLambresa
Copy link
Contributor

Fix issue #1636.

@zm711 zm711 requested a review from apdavison January 29, 2025 21:29
@zm711
Copy link
Contributor

zm711 commented Jan 29, 2025

I activated our test suite and requested Andrew confirm he is okay with this. But this looks fine to me, Andrew can decide if he wants to explicitly test this. Thanks for the contribution.

@apdavison apdavison linked an issue Jan 30, 2025 that may be closed by this pull request
@apdavison apdavison merged commit 720e75e into NeuralEnsemble:master Jan 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

long_field_names option when writing neo blocks in .mat files
3 participants