Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert felt to uint64 in hints where possible #484

Merged
merged 10 commits into from
Jul 3, 2024
Merged

feat: convert felt to uint64 in hints where possible #484

merged 10 commits into from
Jul 3, 2024

Conversation

TAdev0
Copy link
Contributor

@TAdev0 TAdev0 commented Jun 25, 2024

Resolves #383

@TAdev0 TAdev0 self-assigned this Jun 25, 2024
@TAdev0
Copy link
Contributor Author

TAdev0 commented Jun 27, 2024

waiting for usort integration tests merging to finish

@TAdev0 TAdev0 marked this pull request as ready for review June 27, 2024 13:20
@TAdev0
Copy link
Contributor Author

TAdev0 commented Jun 28, 2024

ready for review @cicr99 @har777

cicr99
cicr99 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@cicr99 cicr99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought there were other hints that also needed this update such as SearchSortedLower, or FindElement hints, but I see all of them work already with uint64 when it comes to the size of elements or arrays. That's good. It looks good to me

pkg/hintrunner/zero/zerohint_others.go Outdated Show resolved Hide resolved
@TAdev0 TAdev0 merged commit 707d13f into NethermindEth:main Jul 3, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicr99 cicr99 cicr99 approved these changes

Assignees

@TAdev0 TAdev0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Felt values in hints representing array length
3 participants
@TAdev0 @cicr99 @Sh0g0-1758