-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uint256Add hinter #212
Uint256Add hinter #212
Conversation
I added a few modifications to the implementation of Uint256Add hint in the last commit, so we could use the same one for Uint256AddLow hint, as most of the logic is the same for both |
Doesn't the current 1 field per operander approach work in this case? |
Unfortunately no. The hint uses |
Take a look at https://github.com/NethermindEth/cairo-vm-go/tree/quasilyte_uint256_hint_review I treat operanders list as a memory initializer: the "name" doesn't need to store an entire object, if you want to pass an object as a parameter, passing its beginning is enough since we can then resolve its address to read consecutive felts from the memory. |
Mmmm, that's true. It's certainly more comfortable to write the tests that way, and also I think it's more readable than just passing an array full of values. Yep, I like it. Will change |
I've left a couple of comments, but nothing that keeps this PR from being merged. |
Fixes #187
Fixes #219