pkg/parsers/zero: improve Identifiers typing #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to do less redundant type assertions while handling the zero prog identifiers. We may go even further, but this step is enough for now to make zero hints handler less awkward. The `.([]zero.Reference)` assertion was not working as the slice contained `[]any` instead. Instead of rewriting the code to handle even more weakly typed `any` values, this patch improves the Identifier objects typing. This makes type assertions and slice conversions unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to do less redundant type assertions while handling the zero prog identifiers.
We may go even further, but this step is enough for now to make zero hints handler less awkward.
The
.([]zero.Reference)assertion was not working as the slice contained[]anyinstead.Instead of rewriting the code to handle even more
weakly typed
anyvalues, this patch improves the Identifier objects typing.This makes type assertions and slice conversions unnecessary.