enable gofmt checks in golangci-lint, run gofmt over all files #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that we don't have gofmt checks on our CI. Before golangci-lint was used ~everywhere, people were comparing the `gofmt -s` output manually in their CI scripts. Since we use golangci-lint, we can just add `gofmt` linter and get on with it.
cicr99
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we don't have gofmt checks on our CI. Before golangci-lint was used ~everywhere, people were comparing the
gofmt -soutput manually in their CI scripts. Since we use golangci-lint, we can just addgofmtlinter and get on with it.