Merge pull request #364 from typingduck/fix20MetricsLimit

Fix silent failure publishing to CloudWatch.
Netflix · Nov 12, 2015 · 46aa306 · 46aa306
2 parents 0104f7b + c940a58
commit 46aa306
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/servo-aws/src/main/java/com/netflix/servo/publish/cloudwatch/CloudWatchMetricObserver.java b/servo-aws/src/main/java/com/netflix/servo/publish/cloudwatch/CloudWatchMetricObserver.java
@@ -179,15 +179,13 @@ public void updateImpl(List<Metric> metrics) {
     Preconditions.checkNotNull(metrics, "metrics");
 
     List<Metric> batch = new ArrayList<>(batchSize);
-    int batchCount = 1;
 
     while (!metrics.isEmpty()) {
       Metric m = metrics.remove(0);
       if (m.hasNumberValue()) {
         batch.add(m);
 
-        if (batchCount % batchSize == 0) {
-          ++batchCount;
+        if (batch.size() % batchSize == 0) {
           putMetricData(batch);
           batch.clear();
         }