Bugfix: check for null before calling Base64 encode string from java.…

…util
Netflix · Mar 3, 2023 · 78532e0 · 78532e0
1 parent e63ffb2
commit 78532e0
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/hollow-diff-ui/src/main/java/com/netflix/hollow/diffview/effigy/HollowEffigyFactory.java b/hollow-diff-ui/src/main/java/com/netflix/hollow/diffview/effigy/HollowEffigyFactory.java
@@ -92,7 +92,12 @@ List<Field> createObjectFields(HollowEffigy effigy) {
                 fieldValue = typeDataAccess.readBoolean(effigy.ordinal, i);
                 break;
             case BYTES:
-                fieldValue = base64.encodeToString(typeDataAccess.readBytes(effigy.ordinal, i));
+                byte[] fieldValueBytes = typeDataAccess.readBytes(effigy.ordinal, i);
+                if (fieldValueBytes == null || fieldValueBytes.length == 0) {
+                    fieldValue = fieldValueBytes;
+                } else {
+                    fieldValue = base64.encodeToString(fieldValueBytes);
+                }
                 break;
             case DOUBLE:
                 fieldValue = Double.valueOf(typeDataAccess.readDouble(effigy.ordinal, i));