Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade genie-agent and genie-web to Spring Boot 3 #1225

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

bhou2
Copy link
Contributor

@bhou2 bhou2 commented Feb 4, 2025

No description provided.

@bhou2 bhou2 marked this pull request as draft February 4, 2025 19:59
@@ -25,6 +25,14 @@ license {
exclude "*.txt"
}

dependencyManagement {
imports {
mavenBom "com.amazonaws:aws-java-sdk-bom:1.12.99"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

com.amazonaws is AWS SDK V1 and with Amazon's announcement of end-of-support for AWS SDK for Java v1.x you'll have to move to V2 eventually
(jFYI, both V1 and V2 will continue being supported with upgrade to Spring Boot for now)

@@ -53,7 +61,6 @@ dependencies {
*******************************/

implementation("io.grpc:grpc-netty")
implementation("io.awspring.cloud:spring-cloud-starter-aws")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you sure this is safe to drop? for reference, Spring Cloud 3 starter name is io.awspring.cloud:spring-cloud-aws-starter

dependencyManagement {
imports {
mavenBom "com.amazonaws:aws-java-sdk-bom:1.12.99"
mavenBom "io.awspring.cloud:spring-cloud-aws-dependencies:3.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also

@bhou2 bhou2 force-pushed the upgrade-spring-cloud-aws3 branch from c9d6848 to b6560c9 Compare February 5, 2025 22:33
@bhou2 bhou2 changed the title Upgrade genie-common-internal to spring cloud aws 3 Upgrade genie-agent and genie-web to Spring Boot 3 Feb 11, 2025
@bhou2 bhou2 force-pushed the upgrade-spring-cloud-aws3 branch 3 times, most recently from 4fe4941 to a12dc33 Compare February 11, 2025 02:18
@bhou2 bhou2 force-pushed the upgrade-spring-cloud-aws3 branch from a12dc33 to df46c7c Compare February 11, 2025 02:25
@bhou2 bhou2 force-pushed the upgrade-spring-cloud-aws3 branch 2 times, most recently from 79a96c9 to f1393c1 Compare February 13, 2025 23:11
@bhou2 bhou2 force-pushed the upgrade-spring-cloud-aws3 branch from f1393c1 to 1a6f304 Compare February 16, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants